Gravity update foundation#1219
Merged
Merged
Conversation
…a number of unexpected tiny errors (1e-6) in other tests
Member
|
This seems like a good approach that we could also use for sea level density in the components where it is used. |
…rom that change from all other 1st changes for gravity pr
Update the json test with the new vars.
Kenneth-T-Moore
approved these changes
Jul 8, 2026
jkirk5
reviewed
Jul 10, 2026
| 'm', | ||
| ) # Venus Global Reference Atmospheric Model (Venus-GRAM): User Guide, NASA/TM-20210022168, avg of equatorial and polar radius | ||
|
|
||
| GNS = 9.8236930 # grav_accel_at_surface_earth # remove this asap |
Contributor
There was a problem hiding this comment.
Why was this added in the first place? It's not used anywhere, can we remove it right now?
Contributor
Author
There was a problem hiding this comment.
I commented this line out but left it as a TODO.
GNS is used in a utils.py file. It was hard coded and didn't reference the constants file so it skipped under the radar.
I put it here in constants so we would remember to change it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Mission.GRAVITY. Did not start using this in any components yet. That will be a follow-on PR.
Related Issues
Partial fix for #1192, but more work needs to be done to complete replace constants.
Backwards incompatibilities
None
AI Usage
Disclose any AI usage in this PR, including models used and files affected.